ci2: Add all*config builds#75
Merged
Merged
Conversation
nickdesaulniers
requested changes
Feb 5, 2021
nickdesaulniers
left a comment
nickdesaulniers
left a comment
Member
There was a problem hiding this comment.
Let's see if there's simplifications to be had for the list of configs.
| {"make_variables": build["make_variables"]}) | ||
| tuxsuite_buildset["sets"][0]["builds"] += [current_build] | ||
|
|
||
| if "defconfig" in str(build["config"]): |
Member
There was a problem hiding this comment.
isn't build["config"] already a str? Why convert it again?
Member
Author
There was a problem hiding this comment.
Not necessarily, this could be a list.
It is advantageous to add support for all*config targets, as they will help validate clang and LLVM further. With this change, we add a separate build set when all*configs are detected in the matrix. Having a separate build set will allow us to have two separate tuxsuite instances, one for defconfigs (which should be pretty quick) and one for all*configs, which can afford to take a while. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
We are only enabling allnoconfig right now because of other breakages :( Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
allconfig
branch
from
a1faaea to
c3f5913
Compare
Member
Author
|
Alright, I believe all of your comments should be addressed with this latest series. PTAL. |
nickdesaulniers
approved these changes
Feb 5, 2021
Comment on lines
+78
to
+80
| defconfigs += [current_build] | ||
| else: | ||
| allconfigs += [current_build] |
Member
There was a problem hiding this comment.
.append wouldn't create a new array
Member
Author
There was a problem hiding this comment.
Are you talking about doing this change?
diff --git a/generate_tuxsuite.py b/generate_tuxsuite.py
index ecccea4..e4e8ad0 100755
--- a/generate_tuxsuite.py
+++ b/generate_tuxsuite.py
@@ -75,9 +75,9 @@ def emit_tuxsuite_yml(config, tree):
{"make_variables": build["make_variables"]})
if "defconfig" in str(build["config"]):
- defconfigs += [current_build]
+ defconfigs.append(current_build)
else:
- allconfigs += [current_build]
+ allconfigs.append(current_build)
tuxsuite_buildset["sets"][0]["builds"] = defconfigs
if allconfigs:Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is currently based on #74. I will rebase this after #73 and #74 are merged.
The general structure of this series:
allconfigsbuild-set ingenerate_tuxsuite.pyandgenerate_workflow.py.If you would like anything broken down more, let me know.